ershisan99/flashcards-api
1
0
Fork 0
mirror of https://github.com/ershisan99/flashcards-api.git synced 2025-12-17 12:33:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix orderBy not allowing null

Browse Source
This commit is contained in:
andres
2023-08-12 13:42:44 +02:00
parent e615fe7711
commit 2626bf3815
4 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/modules/cards/cards.controller.ts
View File

@@ -25,7 +25,6 @@ import {
import { JwtAuthGuard } from '../auth/guards' import { JwtAuthGuard } from '../auth/guards'
import { CardsService } from './cards.service'
import { UpdateCardDto } from './dto' import { UpdateCardDto } from './dto'
import { Card } from './entities/cards.entity' import { Card } from './entities/cards.entity'
import { DeleteCardByIdCommand, GetDeckByIdCommand, UpdateCardCommand } from './use-cases' import { DeleteCardByIdCommand, GetDeckByIdCommand, UpdateCardCommand } from './use-cases'
@@ -33,7 +32,7 @@ import { DeleteCardByIdCommand, GetDeckByIdCommand, UpdateCardCommand } from './
@ApiTags('Cards') @ApiTags('Cards')
@Controller('cards') @Controller('cards')
export class CardsController { export class CardsController {
constructor(private readonly decksService: CardsService, private commandBus: CommandBus) {} constructor(private commandBus: CommandBus) {}
@UseGuards(JwtAuthGuard) @UseGuards(JwtAuthGuard)
@ApiOperation({ summary: 'Get card by id', description: 'Get card by id' }) @ApiOperation({ summary: 'Get card by id', description: 'Get card by id' })

2
src/modules/cards/infrastructure/cards.repository.ts
View File

@@ -65,7 +65,7 @@ export class CardsRepository {
orderBy, orderBy,
}: GetAllCardsInDeckDto }: GetAllCardsInDeckDto
): Promise<PaginatedCardsWithGrade> { ): Promise<PaginatedCardsWithGrade> {
if (!orderBy) { if (!orderBy || orderBy === 'null') {
orderBy = 'updated-desc' orderBy = 'updated-desc'
} }
try { try {

3
src/modules/decks/decks.controller.ts
View File

@@ -33,7 +33,6 @@ import { JwtAuthGuard } from '../auth/guards'
import { CreateCardDto, GetAllCardsInDeckDto } from '../cards/dto' import { CreateCardDto, GetAllCardsInDeckDto } from '../cards/dto'
import { Card, PaginatedCards } from '../cards/entities/cards.entity' import { Card, PaginatedCards } from '../cards/entities/cards.entity'
import { DecksService } from './decks.service'
import { CreateDeckDto, GetAllDecksDto, UpdateDeckDto } from './dto' import { CreateDeckDto, GetAllDecksDto, UpdateDeckDto } from './dto'
import { GetRandomCardDto } from './dto/get-random-card.dto' import { GetRandomCardDto } from './dto/get-random-card.dto'
import { Deck, DeckWithAuthor, PaginatedDecks } from './entities/deck.entity' import { Deck, DeckWithAuthor, PaginatedDecks } from './entities/deck.entity'
@@ -52,7 +51,7 @@ import {
@ApiTags('Decks') @ApiTags('Decks')
@Controller('decks') @Controller('decks')
export class DecksController { export class DecksController {
constructor(private readonly decksService: DecksService, private commandBus: CommandBus) {} constructor(private commandBus: CommandBus) {}
@HttpCode(HttpStatus.PARTIAL_CONTENT) @HttpCode(HttpStatus.PARTIAL_CONTENT)
@ApiOperation({ description: 'Retrieve paginated decks list.', summary: 'Paginated decks list' }) @ApiOperation({ description: 'Retrieve paginated decks list.', summary: 'Paginated decks list' })

2
src/modules/decks/infrastructure/decks.repository.ts
View File

@@ -61,7 +61,7 @@ export class DecksRepository {
maxCardsCount, maxCardsCount,
orderBy, orderBy,
}: GetAllDecksDto): Promise<PaginatedDecks> { }: GetAllDecksDto): Promise<PaginatedDecks> {
if (!orderBy) { if (!orderBy || orderBy === 'null') {
orderBy = 'updated-desc' orderBy = 'updated-desc'
} }
try { try {