From 892cee4a7b70da91426949744077cb3151a894b8 Mon Sep 17 00:00:00 2001 From: Andres Date: Sun, 18 Jun 2023 14:52:37 +0200 Subject: [PATCH] refactor a bit --- src/modules/cards/cards.module.ts | 16 ++-------------- src/modules/cards/use-cases/index.ts | 2 -- src/modules/decks/decks.module.ts | 2 +- src/modules/decks/use-cases/index.ts | 1 + .../decks/use-cases/update-deck-use-case.ts | 7 +++++-- todo.md | 2 ++ 6 files changed, 11 insertions(+), 19 deletions(-) create mode 100644 todo.md diff --git a/src/modules/cards/cards.module.ts b/src/modules/cards/cards.module.ts index ef0ca53..4dbcf01 100644 --- a/src/modules/cards/cards.module.ts +++ b/src/modules/cards/cards.module.ts @@ -2,22 +2,10 @@ import { Module } from '@nestjs/common' import { CardsService } from './cards.service' import { CardsController } from './cards.controller' import { CqrsModule } from '@nestjs/cqrs' -import { - CreateCardHandler, - DeleteDeckByIdHandler, - GetDeckByIdHandler, - GetAllCardsInDeckHandler, - UpdateDeckHandler, -} from './use-cases' +import { DeleteDeckByIdHandler, GetDeckByIdHandler, UpdateDeckHandler } from './use-cases' import { CardsRepository } from './infrastructure/cards.repository' -const commandHandlers = [ - CreateCardHandler, - GetAllCardsInDeckHandler, - GetDeckByIdHandler, - DeleteDeckByIdHandler, - UpdateDeckHandler, -] +const commandHandlers = [GetDeckByIdHandler, DeleteDeckByIdHandler, UpdateDeckHandler] @Module({ imports: [CqrsModule], diff --git a/src/modules/cards/use-cases/index.ts b/src/modules/cards/use-cases/index.ts index 8626b90..5f05762 100644 --- a/src/modules/cards/use-cases/index.ts +++ b/src/modules/cards/use-cases/index.ts @@ -1,5 +1,3 @@ -export * from '../../decks/use-cases/create-card-use-case' -export * from '../../decks/use-cases/get-all-cards-in-deck-use-case' export * from './get-deck-by-id-use-case' export * from './delete-deck-by-id-use-case' export * from './update-deck-use-case' diff --git a/src/modules/decks/decks.module.ts b/src/modules/decks/decks.module.ts index 5167c4a..ebb3fea 100644 --- a/src/modules/decks/decks.module.ts +++ b/src/modules/decks/decks.module.ts @@ -9,10 +9,10 @@ import { GetAllDecksHandler, UpdateDeckHandler, GetAllCardsInDeckHandler, + CreateCardHandler, } from './use-cases' import { DecksRepository } from './infrastructure/decks.repository' import { CardsRepository } from '../cards/infrastructure/cards.repository' -import { CreateCardHandler } from './use-cases/create-card-use-case' const commandHandlers = [ CreateDeckHandler, diff --git a/src/modules/decks/use-cases/index.ts b/src/modules/decks/use-cases/index.ts index 1a8b55d..9fd51e7 100644 --- a/src/modules/decks/use-cases/index.ts +++ b/src/modules/decks/use-cases/index.ts @@ -4,3 +4,4 @@ export * from './get-deck-by-id-use-case' export * from './delete-deck-by-id-use-case' export * from './update-deck-use-case' export * from './get-all-cards-in-deck-use-case' +export * from './create-card-use-case' diff --git a/src/modules/decks/use-cases/update-deck-use-case.ts b/src/modules/decks/use-cases/update-deck-use-case.ts index bf008cb..675ebd4 100644 --- a/src/modules/decks/use-cases/update-deck-use-case.ts +++ b/src/modules/decks/use-cases/update-deck-use-case.ts @@ -17,9 +17,12 @@ export class UpdateDeckHandler implements ICommandHandler { async execute(command: UpdateDeckCommand) { const deck = await this.deckRepository.findDeckById(command.deckId) - if (!deck) throw new NotFoundException(`Deck with id ${command.deckId} not found`) + if (!deck) { + throw new NotFoundException(`Deck with id ${command.deckId} not found`) + } + if (deck.userId !== command.userId) { - throw new BadRequestException(`You can't change a deck that you don't own`) + throw new BadRequestException(`You can't modify a deck that you don't own`) } return await this.deckRepository.updateDeckById(command.deckId, command.deck) diff --git a/todo.md b/todo.md new file mode 100644 index 0000000..23732c5 --- /dev/null +++ b/todo.md @@ -0,0 +1,2 @@ +## TODO +- [ ] Rate limit emails \ No newline at end of file