Merge pull request #1457 from coollabsio/next

v4.0.0-beta.136

app/Console/Commands/Init.php

@@ -5,6 +5,7 @@ namespace App\Console\Commands;
 use App\Enums\ApplicationDeploymentStatus;
 use App\Models\Application;
 use App\Models\ApplicationDeploymentQueue;
+use App\Models\InstanceSettings;
 use App\Models\Service;
 use App\Models\ServiceApplication;
 use App\Models\ServiceDatabase;
@@ -14,6 +15,7 @@ use App\Models\StandaloneMysql;
 use App\Models\StandalonePostgresql;
 use App\Models\StandaloneRedis;
 use Illuminate\Console\Command;
+use Illuminate\Support\Facades\Http;
 use Illuminate\Support\Facades\Storage;
 
 class Init extends Command
@@ -23,7 +25,7 @@ class Init extends Command
 
     public function handle()
     {
-        ray()->clearAll();
+        $this->alive();
         $cleanup = $this->option('cleanup');
         if ($cleanup) {
             $this->cleanup_stucked_resources();
@@ -31,7 +33,22 @@ class Init extends Command
         }
         $this->cleanup_in_progress_application_deployments();
     }
-
+    private function alive()
+    {
+        $id = config('app.id');
+        $settings = InstanceSettings::get();
+        $do_not_track = data_get($settings, 'do_not_track');
+        if ($do_not_track == true) {
+            echo "Skipping alive as do_not_track is enabled\n";
+            return;
+        }
+        try {
+            echo "I am alive!\n";
+            Http::get("https://get.coollabs.io/coolify/v4/alive?appId=$id");
+        } catch (\Throwable $e) {
+            echo "Error in alive: {$e->getMessage()}\n";
+        }
+    }
     private function cleanup_ssh()
     {
         try {

app/Exceptions/Handler.php

@@ -4,6 +4,7 @@ namespace App\Exceptions;
 
 use App\Models\InstanceSettings;
 use App\Models\User;
+use Illuminate\Auth\AuthenticationException;
 use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
 use Sentry\Laravel\Integration;
 use Sentry\State\Scope;
@@ -40,6 +41,13 @@ class Handler extends ExceptionHandler
     ];
     private InstanceSettings $settings;
 
+    protected function unauthenticated($request, AuthenticationException $exception)
+    {
+        if ($request->is('api/*') || $request->expectsJson() || $this->shouldReturnJson($request, $exception)) {
+            return response()->json(['message' => $exception->getMessage()], 401);
+        }
+        return  redirect()->guest($exception->redirectTo() ?? route('login'));
+    }
     /**
      * Register the exception handling callbacks for the application.
      */
@@ -47,6 +55,7 @@ class Handler extends ExceptionHandler
     {
         $this->reportable(function (Throwable $e) {
             if (isDev()) {
+                ray($e);
                 return;
             }
             $this->settings = InstanceSettings::get();

app/Http/Livewire/Boarding/Index.php

@@ -33,7 +33,7 @@ class Index extends Component
     public ?string $remoteServerUser = 'root';
     public ?Server $createdServer = null;
 
-    public Collection|array $projects = [];
+    public Collection $projects;
     public ?int $selectedExistingProject = null;
     public ?Project $createdProject = null;
 

app/Http/Livewire/Project/Shared/Webhooks.php

@@ -8,9 +8,27 @@ class Webhooks extends Component
 {
     public $resource;
     public ?string $deploywebhook = null;
+    public ?string $githubManualWebhook = null;
+    public ?string $gitlabManualWebhook = null;
+    protected $rules = [
+        'resource.manual_webhook_secret_github' => 'nullable|string',
+        'resource.manual_webhook_secret_gitlab' => 'nullable|string',
+    ];
+    public function saveSecret()
+    {
+        try {
+            $this->validate();
+            $this->resource->save();
+            $this->emit('success','Secret Saved.');
+        } catch (\Exception $e) {
+            return handleError($e, $this);
+        }
+    }
     public function mount()
     {
         $this->deploywebhook = generateDeployWebhook($this->resource);
+        $this->githubManualWebhook = generateGitManualWebhook($this->resource, 'github');
+        $this->gitlabManualWebhook = generateGitManualWebhook($this->resource, 'gitlab');
     }
     public function render()
     {

app/Http/Livewire/Team/Storage/Create.php

@@ -64,21 +64,10 @@ class Create extends Component
             }
             $this->storage->team_id = currentTeam()->id;
             $this->storage->testConnection();
-            $this->storage->is_usable = true;
             $this->storage->save();
             return redirect()->route('team.storages.show', $this->storage->uuid);
         } catch (\Throwable $e) {
             return handleError($e, $this);
         }
     }
-
-    private function test_s3_connection()
-    {
-        try {
-            $this->storage->testConnection();
-            return $this->emit('success', 'Connection is working. Tested with "ListObjectsV2" action.');
-        } catch (\Throwable $e) {
-            return handleError($e, $this);
-        }
-    }
 }

app/Http/Livewire/Team/Storage/Form.php

@@ -32,7 +32,7 @@ class Form extends Component
     public function test_s3_connection()
     {
         try {
-            $this->storage->testConnection();
+            $this->storage->testConnection(shouldSave: true);
             return $this->emit('success', 'Connection is working. Tested with "ListObjectsV2" action.');
         } catch (\Throwable $e) {
             return handleError($e, $this);
@@ -53,10 +53,7 @@ class Form extends Component
     {
         $this->validate();
         try {
-            $this->storage->testConnection();
-            $this->emit('success', 'Connection is working. Tested with "ListObjectsV2" action.');
-            $this->storage->save();
-            $this->emit('success', 'Storage settings saved.');
+            $this->test_s3_connection();
         } catch (\Throwable $e) {
             return handleError($e, $this);
         }

app/Jobs/ApplicationDeploymentJob.php

@@ -53,6 +53,7 @@ class ApplicationDeploymentJob implements ShouldQueue, ShouldBeEncrypted
     private StandaloneDocker|SwarmDocker $destination;
     private Server $server;
     private ?ApplicationPreview $preview = null;
+    private ?string $git_type = null;
 
     private string $container_name;
     private ?string $currently_running_container_name = null;
@@ -99,6 +100,8 @@ class ApplicationDeploymentJob implements ShouldQueue, ShouldBeEncrypted
         $this->force_rebuild = $this->application_deployment_queue->force_rebuild;
         $this->restart_only = $this->application_deployment_queue->restart_only;
 
+        $this->git_type = data_get($this->application_deployment_queue, 'git_type');
+
         $source = data_get($this->application, 'source');
         if ($source) {
             $this->source = $source->getMorphClass()::where('id', $this->application->source->id)->first();
@@ -189,7 +192,7 @@ class ApplicationDeploymentJob implements ShouldQueue, ShouldBeEncrypted
             $this->customRepository = $this->application->git_repository;
         }
         try {
-            if ($this->restart_only) {
+            if ($this->restart_only && $this->application->build_pack !== 'dockerimage') {
                 $this->just_restart();
             } else if ($this->application->dockerfile) {
                 $this->deploy_simple_dockerfile();
@@ -218,12 +221,16 @@ class ApplicationDeploymentJob implements ShouldQueue, ShouldBeEncrypted
         } finally {
             if (isset($this->docker_compose_base64)) {
                 $readme = generate_readme_file($this->application->name, $this->application_deployment_queue->updated_at);
+                $composeFileName = "$this->configuration_dir/docker-compose.yml";
+                if ($this->pull_request_id !== 0) {
+                    $composeFileName = "$this->configuration_dir/docker-compose-pr-{$this->pull_request_id}.yml";
+                }
                 $this->execute_remote_command(
                     [
                         "mkdir -p $this->configuration_dir"
                     ],
                     [
-                        "echo '{$this->docker_compose_base64}' | base64 -d > $this->configuration_dir/docker-compose.yml",
+                        "echo '{$this->docker_compose_base64}' | base64 -d > $composeFileName",
                     ],
                     [
                         "echo '{$readme}' > $this->configuration_dir/README.md",
@@ -349,7 +356,7 @@ class ApplicationDeploymentJob implements ShouldQueue, ShouldBeEncrypted
         $this->prepare_builder_image();
         $this->execute_remote_command(
             [
-                executeInDocker($this->deployment_uuid, "echo '$dockerfile_base64' | base64 -d > $this->workdir/Dockerfile")
+                executeInDocker($this->deployment_uuid, "echo '$dockerfile_base64' | base64 -d > $this->workdir$this->dockerfile_location")
             ],
         );
         $this->generate_image_names();
@@ -652,7 +659,7 @@ class ApplicationDeploymentJob implements ShouldQueue, ShouldBeEncrypted
                 }
                 if ($this->pull_request_id !== 0) {
                     $this->branch = "pull/{$this->pull_request_id}/head:$pr_branch_name";
-                    $commands->push(executeInDocker($this->deployment_uuid, "cd {$this->basedir} && git fetch origin pull/{$this->pull_request_id}/head:$pr_branch_name && git checkout $pr_branch_name"));
+                    $commands->push(executeInDocker($this->deployment_uuid, "cd {$this->basedir} && git fetch origin $this->branch && git checkout $pr_branch_name"));
                 }
                 return $commands->implode(' && ');
             }
@@ -664,14 +671,28 @@ class ApplicationDeploymentJob implements ShouldQueue, ShouldBeEncrypted
                 throw new Exception('Private key not found. Please add a private key to the application and try again.');
             }
             $private_key = base64_encode($private_key);
-            $git_clone_command = "GIT_SSH_COMMAND=\"ssh -o ConnectTimeout=30 -p {$this->customPort} -o Port={$this->customPort} -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i /root/.ssh/id_rsa\" {$git_clone_command} {$this->customRepository} {$this->basedir}";
-            $git_clone_command = $this->set_git_import_settings($git_clone_command);
+            $git_clone_command_base = "GIT_SSH_COMMAND=\"ssh -o ConnectTimeout=30 -p {$this->customPort} -o Port={$this->customPort} -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i /root/.ssh/id_rsa\" {$git_clone_command} {$this->customRepository} {$this->basedir}";
+            $git_clone_command = $this->set_git_import_settings($git_clone_command_base);
             $commands = collect([
                 executeInDocker($this->deployment_uuid, "mkdir -p /root/.ssh"),
                 executeInDocker($this->deployment_uuid, "echo '{$private_key}' | base64 -d > /root/.ssh/id_rsa"),
                 executeInDocker($this->deployment_uuid, "chmod 600 /root/.ssh/id_rsa"),
-                executeInDocker($this->deployment_uuid, $git_clone_command)
             ]);
+            if ($this->pull_request_id !== 0) {
+                ray($this->git_type);
+                if ($this->git_type === 'gitlab') {
+                    $this->branch = "merge-requests/{$this->pull_request_id}/head:$pr_branch_name";
+                    $commands->push(executeInDocker($this->deployment_uuid, "echo 'Checking out $this->branch'"));
+                    $git_clone_command = "{$git_clone_command} && cd {$this->basedir} && GIT_SSH_COMMAND=\"ssh -o ConnectTimeout=30 -p {$this->customPort} -o Port={$this->customPort} -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i /root/.ssh/id_rsa\" git fetch origin $this->branch && git checkout $pr_branch_name";
+                }
+                if ($this->git_type === 'github') {
+                    $this->branch = "pull/{$this->pull_request_id}/head:$pr_branch_name";
+                    $commands->push(executeInDocker($this->deployment_uuid, "echo 'Checking out $this->branch'"));
+                    $git_clone_command = "{$git_clone_command} && cd {$this->basedir} && GIT_SSH_COMMAND=\"ssh -o ConnectTimeout=30 -p {$this->customPort} -o Port={$this->customPort} -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i /root/.ssh/id_rsa\" git fetch origin $this->branch && git checkout $pr_branch_name";
+                }
+            }
+
+            $commands->push(executeInDocker($this->deployment_uuid, $git_clone_command));
             return $commands->implode(' && ');
         }
         if ($this->application->deploymentType() === 'other') {
@@ -992,7 +1013,7 @@ COPY ./nginx.conf /etc/nginx/conf.d/default.conf");
             }");
             } else {
                 $this->execute_remote_command([
-                    executeInDocker($this->deployment_uuid, "docker build $this->buildTarget $this->addHosts --network host -f {$this->workdir}/{$this->dockerfile_location} {$this->build_args} --progress plain -t $this->build_image_name {$this->workdir}"), "hidden" => true
+                    executeInDocker($this->deployment_uuid, "docker build $this->buildTarget $this->addHosts --network host -f {$this->workdir}{$this->dockerfile_location} {$this->build_args} --progress plain -t $this->build_image_name {$this->workdir}"), "hidden" => true
                 ]);
 
                 $dockerfile = base64_encode("FROM {$this->application->static_image}
@@ -1104,7 +1125,7 @@ COPY ./nginx.conf /etc/nginx/conf.d/default.conf");
     private function add_build_env_variables_to_dockerfile()
     {
         $this->execute_remote_command([
-            executeInDocker($this->deployment_uuid, "cat {$this->workdir}/{$this->dockerfile_location}"), "hidden" => true, "save" => 'dockerfile'
+            executeInDocker($this->deployment_uuid, "cat {$this->workdir}{$this->dockerfile_location}"), "hidden" => true, "save" => 'dockerfile'
         ]);
         $dockerfile = collect(Str::of($this->saved_outputs->get('dockerfile'))->trim()->explode("\n"));
 
@@ -1113,7 +1134,7 @@ COPY ./nginx.conf /etc/nginx/conf.d/default.conf");
         }
         $dockerfile_base64 = base64_encode($dockerfile->implode("\n"));
         $this->execute_remote_command([
-            executeInDocker($this->deployment_uuid, "echo '{$dockerfile_base64}' | base64 -d > {$this->workdir}/{$this->dockerfile_location}"),
+            executeInDocker($this->deployment_uuid, "echo '{$dockerfile_base64}' | base64 -d > {$this->workdir}{$this->dockerfile_location}"),
             "hidden" => true
         ]);
     }

app/Jobs/DatabaseBackupJob.php

@@ -141,21 +141,20 @@ class DatabaseBackupJob implements ShouldQueue, ShouldBeEncrypted
                 } else if ($databaseType === 'standalone-mariadb') {
                     $this->container_name = "{$this->database->name}-$serviceUuid";
                     $this->directory_name = $serviceName . '-' . $this->container_name;
-                    $commands[] = "docker exec $this->container_name env | grep MARIADB_";
+                    $commands[] = "docker exec $this->container_name env";
                     $envs = instant_remote_process($commands, $this->server);
                     $envs = str($envs)->explode("\n");
-
                     $rootPassword = $envs->filter(function ($env) {
                         return str($env)->startsWith('MARIADB_ROOT_PASSWORD=');
                     })->first();
                     if ($rootPassword) {
-                        $this->database->mysql_root_password = str($rootPassword)->after('MARIADB_ROOT_PASSWORD=')->value();
+                        $this->database->mariadb_root_password = str($rootPassword)->after('MARIADB_ROOT_PASSWORD=')->value();
                     } else {
                         $rootPassword = $envs->filter(function ($env) {
                             return str($env)->startsWith('MYSQL_ROOT_PASSWORD=');
                         })->first();
                         if ($rootPassword) {
-                            $this->database->mysql_root_password = str($rootPassword)->after('MYSQL_ROOT_PASSWORD=')->value();
+                            $this->database->mariadb_root_password = str($rootPassword)->after('MYSQL_ROOT_PASSWORD=')->value();
                         }
                     }
 
@@ -435,7 +434,7 @@ class DatabaseBackupJob implements ShouldQueue, ShouldBeEncrypted
             // $region = $this->s3->region;
             $bucket = $this->s3->bucket;
             $endpoint = $this->s3->endpoint;
-            $this->s3->testConnection();
+            $this->s3->testConnection(shouldSave: true);
             if (data_get($this->backup, 'database_type') === 'App\Models\ServiceDatabase') {
                 $network = $this->database->service->destination->network;
             } else {

app/Jobs/DockerCleanupJob.php

@@ -21,15 +21,6 @@ class DockerCleanupJob implements ShouldQueue, ShouldBeEncrypted
     public ?string $dockerRootFilesystem = null;
     public ?int $usageBefore = null;
 
-    public function middleware(): array
-    {
-        return [(new WithoutOverlapping($this->server->uuid))];
-    }
-
-    public function uniqueId(): string
-    {
-        return $this->server->uuid;
-    }
     public function __construct(public Server $server)
     {
     }

app/Models/Application.php

@@ -85,6 +85,18 @@ class Application extends BaseModel
         );
     }
 
+    public function gitWebhook(): Attribute
+    {
+        return Attribute::make(
+            get: function () {
+                if (!is_null($this->source?->html_url) && !is_null($this->git_repository) && !is_null($this->git_branch)) {
+                    return "{$this->source->html_url}/{$this->git_repository}/settings/hooks";
+                }
+                return $this->git_repository;
+            }
+        );
+    }
+
     public function gitCommits(): Attribute
     {
         return Attribute::make(

app/Models/S3Storage.php

@@ -36,14 +36,13 @@ class S3Storage extends BaseModel
         return "{$this->endpoint}/{$this->bucket}";
     }
 
-    public function testConnection()
+    public function testConnection(bool $shouldSave = false)
     {
         try {
             set_s3_target($this);
             Storage::disk('custom-s3')->files();
             $this->unusable_email_sent = false;
             $this->is_usable = true;
-            return;
         } catch (\Throwable $e) {
             $this->is_usable = false;
             if ($this->unusable_email_sent === false && is_transactional_emails_active()) {
@@ -65,7 +64,9 @@ class S3Storage extends BaseModel
 
             throw $e;
         } finally {
-            $this->save();
+            if ($shouldSave) {
+                $this->save();
+            }
         }
     }
 }

app/Models/Server.php

@@ -111,9 +111,9 @@ class Server extends BaseModel
 
     public function hasDefinedResources()
     {
-        $applications = $this->applications()->count() === 0;
-        $databases = $this->databases()->count() === 0;
-        $services = $this->services()->count() === 0;
+        $applications = $this->applications()->count() > 0;
+        $databases = $this->databases()->count() > 0;
+        $services = $this->services()->count() > 0;
         if ($applications || $databases || $services) {
             return true;
         }

app/Models/Service.php

@@ -111,24 +111,36 @@ class Service extends BaseModel
                     $postgres_user = $this->environment_variables()->whereIn('key', $userVariables)->first();
                     $postgres_password = $this->environment_variables()->whereIn('key', $passwordVariables)->first();
                     $postgres_db_name = $this->environment_variables()->whereIn('key', $dbNameVariables)->first();
-                    $fields->put('PostgreSQL', [
-                        'User' => [
-                            'key' => data_get($postgres_user, 'key'),
-                            'value' => data_get($postgres_user, 'value'),
-                            'rules' => 'required',
-                        ],
-                        'Password' => [
-                            'key' => data_get($postgres_password, 'key'),
-                            'value' => data_get($postgres_password, 'value'),
-                            'rules' => 'required',
-                            'isPassword' => true,
-                        ],
-                        'Database Name' => [
-                            'key' => data_get($postgres_db_name, 'key'),
-                            'value' => data_get($postgres_db_name, 'value'),
-                            'rules' => 'required',
-                        ],
-                    ]);
+                    $data = collect([]);
+                    if ($postgres_user) {
+                        $data = $data->merge([
+                            'User' => [
+                                'key' => data_get($postgres_user, 'key'),
+                                'value' => data_get($postgres_user, 'value'),
+                                'rules' => 'required',
+                            ],
+                        ]);
+                    }
+                    if ($postgres_password) {
+                        $data = $data->merge([
+                            'Password' => [
+                                'key' => data_get($postgres_password, 'key'),
+                                'value' => data_get($postgres_password, 'value'),
+                                'rules' => 'required',
+                                'isPassword' => true,
+                            ],
+                        ]);
+                    }
+                    if ($postgres_db_name) {
+                        $data = $data->merge([
+                            'Database Name' => [
+                                'key' => data_get($postgres_db_name, 'key'),
+                                'value' => data_get($postgres_db_name, 'value'),
+                                'rules' => 'required',
+                            ],
+                        ]);
+                    }
+                    $fields->put('PostgreSQL', $data->toArray());
                     break;
                 case str($image)->contains('mysql'):
                     $userVariables = ['SERVICE_USER_MYSQL', 'SERVICE_USER_WORDPRESS'];
@@ -139,30 +151,46 @@ class Service extends BaseModel
                     $mysql_password = $this->environment_variables()->whereIn('key', $passwordVariables)->first();
                     $mysql_root_password = $this->environment_variables()->whereIn('key', $rootPasswordVariables)->first();
                     $mysql_db_name = $this->environment_variables()->whereIn('key', $dbNameVariables)->first();
-                    $fields->put('MySQL', [
-                        'User' => [
-                            'key' => data_get($mysql_user, 'key'),
-                            'value' => data_get($mysql_user, 'value'),
-                            'rules' => 'required',
-                        ],
-                        'Password' => [
-                            'key' => data_get($mysql_password, 'key'),
-                            'value' => data_get($mysql_password, 'value'),
-                            'rules' => 'required',
-                            'isPassword' => true,
-                        ],
-                        'Root Password' => [
-                            'key' => data_get($mysql_root_password, 'key'),
-                            'value' => data_get($mysql_root_password, 'value'),
-                            'rules' => 'required',
-                            'isPassword' => true,
-                        ],
-                        'Database Name' => [
-                            'key' => data_get($mysql_db_name, 'key'),
-                            'value' => data_get($mysql_db_name, 'value'),
-                            'rules' => 'required',
-                        ],
-                    ]);
+                    $data = collect([]);
+                    if ($mysql_user) {
+                        $data = $data->merge([
+                            'User' => [
+                                'key' => data_get($mysql_user, 'key'),
+                                'value' => data_get($mysql_user, 'value'),
+                                'rules' => 'required',
+                            ],
+                        ]);
+                    }
+                    if ($mysql_password) {
+                        $data = $data->merge([
+                            'Password' => [
+                                'key' => data_get($mysql_password, 'key'),
+                                'value' => data_get($mysql_password, 'value'),
+                                'rules' => 'required',
+                                'isPassword' => true,
+                            ],
+                        ]);
+                    }
+                    if ($mysql_root_password) {
+                        $data = $data->merge([
+                            'Root Password' => [
+                                'key' => data_get($mysql_root_password, 'key'),
+                                'value' => data_get($mysql_root_password, 'value'),
+                                'rules' => 'required',
+                                'isPassword' => true,
+                            ],
+                        ]);
+                    }
+                    if ($mysql_db_name) {
+                        $data = $data->merge([
+                            'Database Name' => [
+                                'key' => data_get($mysql_db_name, 'key'),
+                                'value' => data_get($mysql_db_name, 'value'),
+                                'rules' => 'required',
+                            ],
+                        ]);
+                    }
+                    $fields->put('MySQL', $data->toArray());
                     break;
                 case str($image)->contains('mariadb'):
                     $userVariables = ['SERVICE_USER_MARIADB', 'SERVICE_USER_WORDPRESS', '_APP_DB_USER'];
@@ -173,31 +201,47 @@ class Service extends BaseModel
                     $mariadb_password = $this->environment_variables()->whereIn('key', $passwordVariables)->first();
                     $mariadb_root_password = $this->environment_variables()->whereIn('key', $rootPasswordVariables)->first();
                     $mariadb_db_name = $this->environment_variables()->whereIn('key', $dbNameVariables)->first();
-                    $fields->put('MariaDB', [
-                        'User' => [
-                            'key' => data_get($mariadb_user, 'key'),
-                            'value' => data_get($mariadb_user, 'value'),
-                            'rules' => 'required',
-                        ],
-                        'Password' => [
-                            'key' => data_get($mariadb_password, 'key'),
-                            'value' => data_get($mariadb_password, 'value'),
-                            'rules' => 'required',
-                            'isPassword' => true,
-                        ],
-                        'Root Password' => [
-                            'key' => data_get($mariadb_root_password, 'key'),
-                            'value' => data_get($mariadb_root_password, 'value'),
-                            'rules' => 'required',
-                            'isPassword' => true,
-                        ],
-                        'Database Name' => [
-                            'key' => data_get($mariadb_db_name, 'key'),
-                            'value' => data_get($mariadb_db_name, 'value'),
-                            'rules' => data_get($mariadb_db_name, 'value') && 'required',
-                        ],
-                    ]);
+                    $data = collect([]);
 
+                    if ($mariadb_user) {
+                        $data = $data->merge([
+                            'User' => [
+                                'key' => data_get($mariadb_user, 'key'),
+                                'value' => data_get($mariadb_user, 'value'),
+                                'rules' => 'required',
+                            ],
+                        ]);
+                    }
+                    if ($mariadb_password) {
+                        $data = $data->merge([
+                            'Password' => [
+                                'key' => data_get($mariadb_password, 'key'),
+                                'value' => data_get($mariadb_password, 'value'),
+                                'rules' => 'required',
+                                'isPassword' => true,
+                            ],
+                        ]);
+                    }
+                    if ($mariadb_root_password) {
+                        $data = $data->merge([
+                            'Root Password' => [
+                                'key' => data_get($mariadb_root_password, 'key'),
+                                'value' => data_get($mariadb_root_password, 'value'),
+                                'rules' => 'required',
+                                'isPassword' => true,
+                            ],
+                        ]);
+                    }
+                    if ($mariadb_db_name) {
+                        $data = $data->merge([
+                            'Database Name' => [
+                                'key' => data_get($mariadb_db_name, 'key'),
+                                'value' => data_get($mariadb_db_name, 'value'),
+                                'rules' => 'required',
+                            ],
+                        ]);
+                    }
+                    $fields->put('MariaDB', $data->toArray());
                     break;
             }
         }

app/Notifications/Channels/EmailChannel.php

@@ -29,6 +29,10 @@ class EmailChannel
                     ->html((string)$mailMessage->render())
             );
         } catch (Exception $e) {
+            $error = $e->getMessage();
+            if ($error === 'No email settings found.') {
+                throw $e;
+            }
             ray($e->getMessage());
             $message = "EmailChannel error: {$e->getMessage()}. Failed to send email to:";
             if (isset($recepients)) {

bootstrap/helpers/applications.php

@@ -4,7 +4,7 @@ use App\Jobs\ApplicationDeploymentJob;
 use App\Models\Application;
 use App\Models\ApplicationDeploymentQueue;
 
-function queue_application_deployment(int $application_id, string $deployment_uuid, int | null $pull_request_id = 0, string $commit = 'HEAD', bool $force_rebuild = false, bool $is_webhook = false, bool $restart_only = false)
+function queue_application_deployment(int $application_id, string $deployment_uuid, int | null $pull_request_id = 0, string $commit = 'HEAD', bool $force_rebuild = false, bool $is_webhook = false, bool $restart_only = false, ?string $git_type = null)
 {
     $deployment = ApplicationDeploymentQueue::create([
         'application_id' => $application_id,
@@ -14,6 +14,7 @@ function queue_application_deployment(int $application_id, string $deployment_uu
         'is_webhook' => $is_webhook,
         'restart_only' => $restart_only,
         'commit' => $commit,
+        'git_type' => $git_type
     ]);
     $queued_deployments = ApplicationDeploymentQueue::where('application_id', $application_id)->where('status', 'queued')->get()->sortByDesc('created_at');
     $running_deployments = ApplicationDeploymentQueue::where('application_id', $application_id)->where('status', 'in_progress')->get()->sortByDesc('created_at');

bootstrap/helpers/docker.php

@@ -153,7 +153,6 @@ function generateServiceSpecificFqdns($service, $forTraefik = false)
         case $type->contains('minio'):
             $MINIO_BROWSER_REDIRECT_URL = $variables->where('key', 'MINIO_BROWSER_REDIRECT_URL')->first();
             $MINIO_SERVER_URL = $variables->where('key', 'MINIO_SERVER_URL')->first();
-            return $payload;
             if (is_null($MINIO_BROWSER_REDIRECT_URL) || is_null($MINIO_SERVER_URL)) {
                 return $payload;
             }

bootstrap/helpers/github.php

@@ -50,8 +50,11 @@ function generate_github_jwt_token(GithubApp $source)
     return $issuedToken;
 }
 
-function githubApi(GithubApp|GitlabApp $source, string $endpoint, string $method = 'get', array|null $data = null, bool $throwError = true)
+function githubApi(GithubApp|GitlabApp|null $source, string $endpoint, string $method = 'get', array|null $data = null, bool $throwError = true)
 {
+    if (is_null($source)) {
+        throw new \Exception('Not implemented yet.');
+    }
     if ($source->getMorphClass() == 'App\Models\GithubApp') {
         if ($source->is_public) {
             $response = Http::github($source->api_url)->$method($endpoint);

bootstrap/helpers/shared.php

@@ -510,6 +510,17 @@ function generateDeployWebhook($resource)
     $url = $api . $endpoint . "?uuid=$uuid&force=false";
     return $url;
 }
+function generateGitManualWebhook($resource, $type) {
+    if ($resource->source_id !== 0 && !is_null($resource->source_id)) {
+        return null;
+    }
+    if ($resource->getMorphClass() === 'App\Models\Application') {
+        $baseUrl = base_url();
+        $api = Url::fromString($baseUrl) . "/webhooks/source/$type/events/manual";
+        return $api;
+    }
+    return null;
+}
 function removeAnsiColors($text)
 {
     return preg_replace('/\e[[][A-Za-z0-9];?[0-9]*m?/', '', $text);

config/sentry.php

@@ -7,7 +7,7 @@ return [
 
     // The release version of your application
     // Example with dynamic git hash: trim(exec('git --git-dir ' . base_path('.git') . ' log --pretty="%h" -n1 HEAD'))
-    'release' => '4.0.0-beta.128',
+    'release' => '4.0.0-beta.136',
     // When left empty or `null` the Laravel environment will be used
     'environment' => config('app.env'),
 

config/version.php

@@ -1,3 +1,3 @@
 <?php
 
-return '4.0.0-beta.128';
+return '4.0.0-beta.136';

database/migrations/2023_11_14_103450_add_manual_webhook_secret.php

@@ -0,0 +1,30 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+return new class extends Migration
+{
+    /**
+     * Run the migrations.
+     */
+    public function up(): void
+    {
+        Schema::table('applications', function (Blueprint $table) {
+            $table->string('manual_webhook_secret_github')->nullable();
+            $table->string('manual_webhook_secret_gitlab')->nullable();
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     */
+    public function down(): void
+    {
+        Schema::table('applications', function (Blueprint $table) {
+            $table->dropColumn('manual_webhook_secret_github');
+            $table->dropColumn('manual_webhook_secret_gitlab');
+        });
+    }
+};

database/migrations/2023_11_14_121416_add_git_type.php

@@ -0,0 +1,34 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+return new class extends Migration
+{
+    /**
+     * Run the migrations.
+     */
+    public function up(): void
+    {
+        Schema::table('application_previews', function (Blueprint $table) {
+            $table->string('git_type')->nullable();
+        });
+        Schema::table('application_deployment_queues', function (Blueprint $table) {
+            $table->string('git_type')->nullable();
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     */
+    public function down(): void
+    {
+        Schema::table('application_previews', function (Blueprint $table) {
+            $table->dropColumn('git_type');
+        });
+        Schema::table('application_deployment_queues', function (Blueprint $table) {
+            $table->dropColumn('git_type');
+        });
+    }
+};

package-lock.json

@@ -16,7 +16,7 @@
                 "axios": "1.5.1",
                 "laravel-vite-plugin": "0.8.1",
                 "postcss": "8.4.31",
-                "tailwindcss": "3.3.3",
+                "tailwindcss": "3.3.5",
                 "vite": "4.4.11",
                 "vue": "3.3.4"
             }
@@ -1051,9 +1051,9 @@
             "dev": true
         },
         "node_modules/fast-glob": {
-            "version": "3.2.12",
-            "resolved": "https://registry.npmjs.org/fast-glob/-/fast-glob-3.2.12.tgz",
-            "integrity": "sha512-DVj4CQIYYow0BlaelwK1pHl5n5cRSJfM60UA0zK891sVInoPri2Ekj7+e1CT3/3qxXenpI+nBBmQAcJPJgaj4w==",
+            "version": "3.3.2",
+            "resolved": "https://registry.npmjs.org/fast-glob/-/fast-glob-3.3.2.tgz",
+            "integrity": "sha512-oX2ruAFQwf/Orj8m737Y5adxDQO0LAB7/S5MnxCdTNDd4p6BsyIVsv9JQsATbTSq8KHRpLwIHbVlUNatxd+1Ow==",
             "dependencies": {
                 "@nodelib/fs.stat": "^2.0.2",
                 "@nodelib/fs.walk": "^1.2.3",
@@ -1283,9 +1283,9 @@
             }
         },
         "node_modules/jiti": {
-            "version": "1.18.2",
-            "resolved": "https://registry.npmjs.org/jiti/-/jiti-1.18.2.tgz",
-            "integrity": "sha512-QAdOptna2NYiSSpv0O/BwoHBSmz4YhpzJHyi+fnMRTXFjp7B8i/YG5Z8IfusxB1ufjcD2Sre1F3R+nX3fvy7gg==",
+            "version": "1.21.0",
+            "resolved": "https://registry.npmjs.org/jiti/-/jiti-1.21.0.tgz",
+            "integrity": "sha512-gFqAIbuKyyso/3G2qhiO2OM6shY6EPP/R0+mkDbyspxKazh8BXDC5FiFsUjlczgdNz/vfra0da2y+aHrusLG/Q==",
             "bin": {
                 "jiti": "bin/jiti.js"
             }
@@ -1808,19 +1808,19 @@
             }
         },
         "node_modules/tailwindcss": {
-            "version": "3.3.3",
-            "resolved": "https://registry.npmjs.org/tailwindcss/-/tailwindcss-3.3.3.tgz",
-            "integrity": "sha512-A0KgSkef7eE4Mf+nKJ83i75TMyq8HqY3qmFIJSWy8bNt0v1lG7jUcpGpoTFxAwYcWOphcTBLPPJg+bDfhDf52w==",
+            "version": "3.3.5",
+            "resolved": "https://registry.npmjs.org/tailwindcss/-/tailwindcss-3.3.5.tgz",
+            "integrity": "sha512-5SEZU4J7pxZgSkv7FP1zY8i2TIAOooNZ1e/OGtxIEv6GltpoiXUqWvLy89+a10qYTB1N5Ifkuw9lqQkN9sscvA==",
             "dependencies": {
                 "@alloc/quick-lru": "^5.2.0",
                 "arg": "^5.0.2",
                 "chokidar": "^3.5.3",
                 "didyoumean": "^1.2.2",
                 "dlv": "^1.1.3",
-                "fast-glob": "^3.2.12",
+                "fast-glob": "^3.3.0",
                 "glob-parent": "^6.0.2",
                 "is-glob": "^4.0.3",
-                "jiti": "^1.18.2",
+                "jiti": "^1.19.1",
                 "lilconfig": "^2.1.0",
                 "micromatch": "^4.0.5",
                 "normalize-path": "^3.0.0",

resources/views/livewire/project/application/general.blade.php

@@ -69,10 +69,12 @@
                 <div class="flex flex-col gap-2 xl:flex-row">
                     <x-forms.input placeholder="/" id="application.base_directory" label="Base Directory"
                         helper="Directory to use as root. Useful for monorepos." />
-                    @if ($application->build_pack === 'dockerfile')
+                    @if ($application->build_pack === 'dockerfile' && !$application->dockerfile)
                         <x-forms.input placeholder="/Dockerfile" id="application.dockerfile_location"
                             label="Dockerfile Location"
                             helper="It is calculated together with the Base Directory: {{ Str::start($application->base_directory . $application->dockerfile_location, '/') }}" />
+                    @endif
+                    @if ($application->build_pack === 'dockerfile')
                         <x-forms.input id="application.dockerfile_target_build" label="Docker Build Stage Target"
                             helper="Useful if you have multi-staged dockerfile." />
                     @endif

resources/views/livewire/project/shared/webhooks.blade.php

@@ -1,10 +1,41 @@
-<div>
+<div class="flex flex-col gap-2">
     <div class="flex items-center gap-2">
         <h2>Webhooks</h2>
         <x-helper
             helper="For more details goto our <a class='text-white underline' href='https://coolify.io/docs/api-endpoints' target='_blank'>docs</a>." />
     </div>
     <div>
-        <x-forms.input readonly label="Deploy Webhook (auth required)" id="deploywebhook"></x-forms.input>
+        <x-forms.input readonly
+            helper="See details in our <a target='_blank' class='text-white underline' href='https://coolify.io/docs/api-authentication'>documentation</a>."
+            label="Deploy Webhook (auth required)" id="deploywebhook"></x-forms.input>
+    </div>
+    <div>
+        <h3>Manual Git Webhooks</h3>
+        @if ($githubManualWebhook && $gitlabManualWebhook)
+            <form wire:submit.prevent='saveSecret' class="flex flex-col gap-2">
+                <div class="flex items-end gap-2">
+                    <x-forms.input helper="Content Type in GitHub configuration could be json or form-urlencoded."
+                        readonly label="GitHub" id="githubManualWebhook"></x-forms.input>
+                    <x-forms.input type="password"
+                        helper="Need to set a secret to be able to use this webhook. It should match with the secret in GitHub."
+                        label="GitHub Webhook Secret" id="resource.manual_webhook_secret_github"></x-forms.input>
+
+                </div>
+                <a target="_blank" class="flex hover:no-underline" href="{{ $resource?->gitWebhook }}">
+                    <x-forms.button>Webhook Configuration on GitHub
+                        <x-external-link />
+                    </x-forms.button>
+                </a>
+                <div class="flex gap-2">
+                    <x-forms.input readonly label="GitLab" id="gitlabManualWebhook"></x-forms.input>
+                    <x-forms.input type="password"
+                        helper="Need to set a secret to be able to use this webhook. It should match with the secret in GitLab."
+                        label="GitLab Webhook Secret" id="resource.manual_webhook_secret_gitlab"></x-forms.input>
+                </div>
+                <x-forms.button type="submit">Save</x-forms.button>
+            </form>
+        @else
+            You are using an official Git App. You do not need manual webhooks.
+        @endif
     </div>
 </div>

resources/views/livewire/team/storage/create.blade.php

@@ -1,6 +1,6 @@
 <div>
     <h1>Create a new S3 Storage</h1>
-    <div class="subtitle ">S3 Storage used to save backups / files</div>
+    <div class="subtitle">S3 Storage used to save backups / files</div>
     <form class="flex flex-col gap-2" wire:submit.prevent='submit'>
         <div class="flex gap-2">
             <x-forms.input label="Name" id="name" />

routes/webhooks.php

@@ -63,6 +63,244 @@ Route::get('/source/github/install', function () {
         return handleError($e);
     }
 });
+Route::post('/source/gitlab/events/manual', function () {
+    try {
+        $payload = request()->collect();
+        $headers = request()->headers->all();
+        ray($payload, $headers);
+        $x_gitlab_token = data_get($headers, 'x-gitlab-token.0');
+        $x_gitlab_event = data_get($payload, 'object_kind');
+        if ($x_gitlab_event === 'push') {
+            $branch = data_get($payload, 'ref');
+            $full_name = data_get($payload, 'project.path_with_namespace');
+            if (Str::isMatch('/refs\/heads\/*/', $branch)) {
+                $branch = Str::after($branch, 'refs/heads/');
+            }
+            if (!$branch) {
+                return response('Nothing to do. No branch found in the request.');
+            }
+            ray('Manual Webhook GitLab Push Event with branch: ' . $branch);
+        }
+        if ($x_gitlab_event === 'merge_request') {
+            $action = data_get($payload, 'object_attributes.action');
+            ray($action);
+            $branch = data_get($payload, 'object_attributes.source_branch');
+            $base_branch = data_get($payload, 'object_attributes.target_branch');
+            $full_name = data_get($payload, 'project.path_with_namespace');
+            $pull_request_id = data_get($payload, 'object_attributes.iid');
+            $pull_request_html_url = data_get($payload, 'object_attributes.url');
+            if (!$branch) {
+                return response('Nothing to do. No branch found in the request.');
+            }
+            ray('Webhook GitHub Pull Request Event with branch: ' . $branch . ' and base branch: ' . $base_branch . ' and pull request id: ' . $pull_request_id);
+        }
+        $applications = Application::where('git_repository', 'like', "%$full_name%");
+        if ($x_gitlab_event === 'push') {
+            $applications = $applications->where('git_branch', $branch)->get();
+            if ($applications->isEmpty()) {
+                return response("Nothing to do. No applications found with deploy key set, branch is '$branch' and Git Repository name has $full_name.");
+            }
+        }
+        if ($x_gitlab_event === 'merge_request') {
+            $applications = $applications->where('git_branch', $base_branch)->get();
+            if ($applications->isEmpty()) {
+                return response("Nothing to do. No applications found with branch '$base_branch'.");
+            }
+        }
+        foreach ($applications as $application) {
+            $webhook_secret = data_get($application, 'manual_webhook_secret_gitlab');
+            if ($webhook_secret !== $x_gitlab_token) {
+                ray('Invalid signature');
+                continue;
+            }
+            $isFunctional = $application->destination->server->isFunctional();
+            if (!$isFunctional) {
+                ray('Server is not functional: ' . $application->destination->server->name);
+                continue;
+            }
+            if ($x_gitlab_event === 'push') {
+                if ($application->isDeployable()) {
+                    ray('Deploying ' . $application->name . ' with branch ' . $branch);
+                    $deployment_uuid = new Cuid2(7);
+                    queue_application_deployment(
+                        application_id: $application->id,
+                        deployment_uuid: $deployment_uuid,
+                        force_rebuild: false,
+                        is_webhook: true
+                    );
+                } else {
+                    ray('Deployments disabled for ' . $application->name);
+                }
+            }
+            if ($x_gitlab_event === 'merge_request') {
+                if ($action === 'opened' || $action === 'synchronize' || $action === 'reopened' || $action === 'reopen' || $action === 'update') {
+                    if ($application->isPRDeployable()) {
+                        $deployment_uuid = new Cuid2(7);
+                        $found = ApplicationPreview::where('application_id', $application->id)->where('pull_request_id', $pull_request_id)->first();
+                        if (!$found) {
+                            ApplicationPreview::create([
+                                'git_type' => 'gitlab',
+                                'application_id' => $application->id,
+                                'pull_request_id' => $pull_request_id,
+                                'pull_request_html_url' => $pull_request_html_url,
+                            ]);
+                        }
+                        queue_application_deployment(
+                            application_id: $application->id,
+                            pull_request_id: $pull_request_id,
+                            deployment_uuid: $deployment_uuid,
+                            force_rebuild: false,
+                            is_webhook: true,
+                            git_type: 'gitlab'
+                        );
+                        ray('Deploying preview for ' . $application->name . ' with branch ' . $branch . ' and base branch ' . $base_branch . ' and pull request id ' . $pull_request_id);
+                        return response('Preview Deployment queued.');
+                    } else {
+                        ray('Preview deployments disabled for ' . $application->name);
+                        return response('Nothing to do. Preview Deployments disabled.');
+                    }
+                }
+                if ($action === 'closed') {
+                    $found = ApplicationPreview::where('application_id', $application->id)->where('pull_request_id', $pull_request_id)->first();
+                    if ($found) {
+                        $found->delete();
+                        $container_name = generateApplicationContainerName($application, $pull_request_id);
+                        // ray('Stopping container: ' . $container_name);
+                        instant_remote_process(["docker rm -f $container_name"], $application->destination->server);
+                        return response('Preview Deployment closed.');
+                    }
+                    return response('Nothing to do. No Preview Deployment found');
+                }
+            }
+        }
+    } catch (Exception $e) {
+        ray($e->getMessage());
+        return handleError($e);
+    }
+});
+Route::post('/source/github/events/manual', function () {
+    try {
+        $x_github_event = Str::lower(request()->header('X-GitHub-Event'));
+        $x_hub_signature_256 = Str::after(request()->header('X-Hub-Signature-256'), 'sha256=');
+        $content_type = request()->header('Content-Type');
+        $payload = request()->collect();
+        if ($x_github_event === 'ping') {
+            // Just pong
+            return response('pong');
+        }
+
+        if ($content_type !== 'application/json') {
+            $payload = json_decode(data_get($payload, 'payload'), true);
+        }
+        if ($x_github_event === 'push') {
+            $branch = data_get($payload, 'ref');
+            $full_name = data_get($payload, 'repository.full_name');
+            if (Str::isMatch('/refs\/heads\/*/', $branch)) {
+                $branch = Str::after($branch, 'refs/heads/');
+            }
+            ray('Manual Webhook GitHub Push Event with branch: ' . $branch);
+        }
+        if ($x_github_event === 'pull_request') {
+            $action = data_get($payload, 'action');
+            $full_name = data_get($payload, 'repository.full_name');
+            $pull_request_id = data_get($payload, 'number');
+            $pull_request_html_url = data_get($payload, 'pull_request.html_url');
+            $branch = data_get($payload, 'pull_request.head.ref');
+            $base_branch = data_get($payload, 'pull_request.base.ref');
+            ray('Webhook GitHub Pull Request Event with branch: ' . $branch . ' and base branch: ' . $base_branch . ' and pull request id: ' . $pull_request_id);
+        }
+        if (!$branch) {
+            return response('Nothing to do. No branch found in the request.');
+        }
+        $applications = Application::where('git_repository', 'like', "%$full_name%");
+        if ($x_github_event === 'push') {
+            $applications = $applications->where('git_branch', $branch)->get();
+            if ($applications->isEmpty()) {
+                return response("Nothing to do. No applications found with deploy key set, branch is '$branch' and Git Repository name has $full_name.");
+            }
+        }
+        if ($x_github_event === 'pull_request') {
+            $applications = $applications->where('git_branch', $base_branch)->get();
+            if ($applications->isEmpty()) {
+                return response("Nothing to do. No applications found with branch '$base_branch'.");
+            }
+        }
+        ray($applications);
+        foreach ($applications as $application) {
+            ray($application);
+            $webhook_secret = data_get($application, 'manual_webhook_secret_github');
+            ray($webhook_secret);
+            $hmac = hash_hmac('sha256', request()->getContent(), $webhook_secret);
+            ray($hmac, $x_hub_signature_256);
+            if (!hash_equals($x_hub_signature_256, $hmac)) {
+                ray('Invalid signature');
+                continue;
+            }
+            $isFunctional = $application->destination->server->isFunctional();
+            if (!$isFunctional) {
+                ray('Server is not functional: ' . $application->destination->server->name);
+                continue;
+            }
+            if ($x_github_event === 'push') {
+                if ($application->isDeployable()) {
+                    ray('Deploying ' . $application->name . ' with branch ' . $branch);
+                    $deployment_uuid = new Cuid2(7);
+                    queue_application_deployment(
+                        application_id: $application->id,
+                        deployment_uuid: $deployment_uuid,
+                        force_rebuild: false,
+                        is_webhook: true
+                    );
+                } else {
+                    ray('Deployments disabled for ' . $application->name);
+                }
+            }
+            if ($x_github_event === 'pull_request') {
+                if ($action === 'opened' || $action === 'synchronize' || $action === 'reopened') {
+                    if ($application->isPRDeployable()) {
+                        $deployment_uuid = new Cuid2(7);
+                        $found = ApplicationPreview::where('application_id', $application->id)->where('pull_request_id', $pull_request_id)->first();
+                        if (!$found) {
+                            ApplicationPreview::create([
+                                'git_type' => 'github',
+                                'application_id' => $application->id,
+                                'pull_request_id' => $pull_request_id,
+                                'pull_request_html_url' => $pull_request_html_url,
+                            ]);
+                        }
+                        queue_application_deployment(
+                            application_id: $application->id,
+                            pull_request_id: $pull_request_id,
+                            deployment_uuid: $deployment_uuid,
+                            force_rebuild: false,
+                            is_webhook: true,
+                            git_type: 'github'
+                        );
+                        ray('Deploying preview for ' . $application->name . ' with branch ' . $branch . ' and base branch ' . $base_branch . ' and pull request id ' . $pull_request_id);
+                        return response('Preview Deployment queued.');
+                    } else {
+                        ray('Preview deployments disabled for ' . $application->name);
+                        return response('Nothing to do. Preview Deployments disabled.');
+                    }
+                }
+                if ($action === 'closed') {
+                    $found = ApplicationPreview::where('application_id', $application->id)->where('pull_request_id', $pull_request_id)->first();
+                    if ($found) {
+                        $found->delete();
+                        $container_name = generateApplicationContainerName($application, $pull_request_id);
+                        // ray('Stopping container: ' . $container_name);
+                        instant_remote_process(["docker rm -f $container_name"], $application->destination->server);
+                        return response('Preview Deployment closed.');
+                    }
+                    return response('Nothing to do. No Preview Deployment found');
+                }
+            }
+        }
+    } catch (Exception $e) {
+        ray($e->getMessage());
+        return handleError($e);
+    }
+});
 Route::post('/source/github/events', function () {
     try {
         $id = null;
@@ -150,6 +388,7 @@ Route::post('/source/github/events', function () {
                         $found = ApplicationPreview::where('application_id', $application->id)->where('pull_request_id', $pull_request_id)->first();
                         if (!$found) {
                             ApplicationPreview::create([
+                                'git_type' => 'github',
                                 'application_id' => $application->id,
                                 'pull_request_id' => $pull_request_id,
                                 'pull_request_html_url' => $pull_request_html_url,
@@ -160,7 +399,8 @@ Route::post('/source/github/events', function () {
                             pull_request_id: $pull_request_id,
                             deployment_uuid: $deployment_uuid,
                             force_rebuild: false,
-                            is_webhook: true
+                            is_webhook: true,
+                            git_type: 'github'
                         );
                         ray('Deploying preview for ' . $application->name . ' with branch ' . $branch . ' and base branch ' . $base_branch . ' and pull request id ' . $pull_request_id);
                         return response('Preview Deployment queued.');
@@ -169,7 +409,7 @@ Route::post('/source/github/events', function () {
                         return response('Nothing to do. Preview Deployments disabled.');
                     }
                 }
-                if ($action === 'closed') {
+                if ($action === 'closed' || $action === 'close') {
                     $found = ApplicationPreview::where('application_id', $application->id)->where('pull_request_id', $pull_request_id)->first();
                     if ($found) {
                         $found->delete();

versions.json

@@ -4,7 +4,7 @@
             "version": "3.12.36"
         },
         "v4": {
-            "version": "4.0.0-beta.128"
+            "version": "4.0.0-beta.136"
         }
     }
 }