Merge pull request #2022 from coollabsio/next

v4.0.0-beta.264

app/Jobs/ApplicationDeploymentJob.php

@@ -741,7 +741,7 @@ class ApplicationDeploymentJob implements ShouldQueue, ShouldBeEncrypted
                 }
             }
         } else {
-            $this->env_filename = ".env-coolify";
+            $this->env_filename = ".env";
             foreach ($this->application->environment_variables as $env) {
                 $real_value = $env->real_value;
                 if ($env->version === '4.0.0-beta.239') {
@@ -785,27 +785,27 @@ class ApplicationDeploymentJob implements ShouldQueue, ShouldBeEncrypted
             $this->env_filename = null;
             return;
         }
-        $this->execute_remote_command([
-            executeInDocker($this->deployment_uuid, "cat $this->workdir/.env 2>/dev/null || true"),
-            "hidden" => true,
-            "save" => "dotenv"
-        ]);
-        if (str($this->saved_outputs->get('dotenv'))->isNotEmpty()) {
-            $base64_dotenv = base64_encode($this->saved_outputs->get('dotenv')->value());
-            $this->execute_remote_command(
-                [
-                    "echo '{$base64_dotenv}' | base64 -d | tee $this->configuration_dir/.env > /dev/null"
-                ]
-            );
-        } else {
-            $this->execute_remote_command(
-                [
-                    "command" => "rm -f $this->configuration_dir/.env",
-                    "hidden" => true,
-                    "ignore_errors" => true
-                ]
-            );
-        }
+        // $this->execute_remote_command([
+        //     executeInDocker($this->deployment_uuid, "cat $this->workdir/.env 2>/dev/null || true"),
+        //     "hidden" => true,
+        //     "save" => "dotenv"
+        // ]);
+        // if (str($this->saved_outputs->get('dotenv'))->isNotEmpty()) {
+        //     $base64_dotenv = base64_encode($this->saved_outputs->get('dotenv')->value());
+        //     $this->execute_remote_command(
+        //         [
+        //             "echo '{$base64_dotenv}' | base64 -d | tee $this->configuration_dir/.env > /dev/null"
+        //         ]
+        //     );
+        // } else {
+        //     $this->execute_remote_command(
+        //         [
+        //             "command" => "rm -f $this->configuration_dir/.env",
+        //             "hidden" => true,
+        //             "ignore_errors" => true
+        //         ]
+        //     );
+        // }
         $envs_base64 = base64_encode($envs->implode("\n"));
         $this->execute_remote_command(
             [
@@ -1281,21 +1281,23 @@ class ApplicationDeploymentJob implements ShouldQueue, ShouldBeEncrypted
                 ]
             ]
         ];
-        if (str($this->saved_outputs->get('dotenv'))->isNotEmpty()) {
-            if (data_get($docker_compose, "services.{$this->container_name}.env_file")) {
-                $docker_compose['services'][$this->container_name]['env_file'][] = '.env';
-            } else {
-                $docker_compose['services'][$this->container_name]['env_file'] = ['.env'];
-            }
-        }
+        // if (str($this->saved_outputs->get('dotenv'))->isNotEmpty()) {
+        //     if (data_get($docker_compose, "services.{$this->container_name}.env_file")) {
+        //         $docker_compose['services'][$this->container_name]['env_file'][] = '.env';
+        //     } else {
+        //         $docker_compose['services'][$this->container_name]['env_file'] = ['.env'];
+        //     }
+        // }
+        // if ($this->env_filename) {
+        //     if (data_get($docker_compose, "services.{$this->container_name}.env_file")) {
+        //         $docker_compose['services'][$this->container_name]['env_file'][] = $this->env_filename;
+        //     } else {
+        //         $docker_compose['services'][$this->container_name]['env_file'] = [$this->env_filename];
+        //     }
+        // }
         if ($this->env_filename) {
-            if (data_get($docker_compose, "services.{$this->container_name}.env_file")) {
-                $docker_compose['services'][$this->container_name]['env_file'][] = $this->env_filename;
-            } else {
-                $docker_compose['services'][$this->container_name]['env_file'] = [$this->env_filename];
-            }
+            $docker_compose['services'][$this->container_name]['env_file'] = [$this->env_filename];
         }
-
         if (!$this->custom_healthcheck_found) {
             $docker_compose['services'][$this->container_name]['healthcheck'] = [
                 'test' => [

app/Livewire/Settings/Configuration.php

@@ -69,13 +69,14 @@ class Configuration extends Component
             }
             $this->validate();
 
-            if ($this->settings->is_dns_validation_enabled) {
+            if ($this->settings->is_dns_validation_enabled && $this->settings->fqdn) {
+                ray('asdf');
                 if (!validate_dns_entry($this->settings->fqdn, $this->server)) {
                     $this->dispatch('error',  "Validating DNS ({$this->settings->fqdn}) failed.<br><br>Make sure you have added the DNS records correctly.<br><br>Check this <a target='_blank' class='underline dark:text-white' href='https://coolify.io/docs/knowledge-base/dns-configuration'>documentation</a> for further help.");
                     $error_show = true;
                 }
             }
-            check_domain_usage(domain: $this->settings->fqdn);
+            if ($this->settings->fqdn) check_domain_usage(domain: $this->settings->fqdn);
             $this->settings->custom_dns_servers = str($this->settings->custom_dns_servers)->replaceEnd(',', '')->trim();
             $this->settings->custom_dns_servers = str($this->settings->custom_dns_servers)->trim()->explode(',')->map(function ($dns) {
                 return str($dns)->trim()->lower();

config/sentry.php

@@ -7,7 +7,7 @@ return [
 
     // The release version of your application
     // Example with dynamic git hash: trim(exec('git --git-dir ' . base_path('.git') . ' log --pretty="%h" -n1 HEAD'))
-    'release' => '4.0.0-beta.262',
+    'release' => '4.0.0-beta.264',
     // When left empty or `null` the Laravel environment will be used
     'environment' => config('app.env'),
 

config/version.php

@@ -1,3 +1,3 @@
 <?php
 
-return '4.0.0-beta.262';
+return '4.0.0-beta.264';

versions.json

@@ -1,7 +1,7 @@
 {
     "coolify": {
         "v4": {
-            "version": "4.0.0-beta.262"
+            "version": "4.0.0-beta.264"
         }
     }
 }